Implement predict in ensembles
#972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-972--etna-docs.netlify.app |
alex-hse-repository
suggested changes
Oct 4, 2022
| def test_forecast_calls_vote(example_tsds: TSDataset, naive_pipeline_1: Pipeline, naive_pipeline_2: Pipeline): | ||
| ensemble = VotingEnsemble(pipelines=[naive_pipeline_1, naive_pipeline_2]) | ||
| ensemble.fit(ts=example_tsds) | ||
| ensemble._vote = MagicMock() |
There was a problem hiding this comment.
Do we actually need MagicMock here, why not just Mock?
There was a problem hiding this comment.
I just use MagicMock everywhere. Should I replace it with Mock?
There was a problem hiding this comment.
As i understand MagicMock is useful testing the magic methods, but here we don't need it
Codecov Report
@@ Coverage Diff @@
## inference #972 +/- ##
============================================
Coverage ? 85.25%
============================================
Files ? 132
Lines ? 7710
Branches ? 0
============================================
Hits ? 6573
Misses ? 1137
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
approved these changes
Oct 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #959.
Closing issues
Closes #959.